Update direct-from-maven 3rd party dependencies in the target

[merks]

No description provided.

[merks]

/request-license-review

[github-actions]

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/7084117929

[merks]

I think the license tool is just broken at the moment. 😱

Note that I did builds for all these versions via this build yesterday:

https://ci.eclipse.org/orbit/job/orbit-simrel-maven-osgi/

Yesterday a few reviews were opened.

[INFO] This content is either not correctly mapped by the system, or requires review.
[INFO] A review is required for maven/mavencentral/org.jsoup/jsoup/1.17.1.
[INFO] A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11785 .
[INFO] A review is required for maven/mavencentral/org.mockito/mockito-junit-jupiter/5.8.0.
[INFO] A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11786 .
[INFO] A review is required for maven/mavencentral/commons-logging/commons-logging/1.3.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11783 .
[INFO] A review is required for maven/mavencentral/org.mockito/mockito-core/5.8.0.

But they were all closed by this morning, and a full build with strict dash license checking passed...

[merks]

@akurtakov

I wonder if something in JDT has changed to cause new problems. From this linke:

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/7084117929

I see this

But that all looks quite bogus...

[iloveeclipse]

I wonder if something in JDT has changed to cause new problems

There were changes in maven build like eclipse-jdt/eclipse.jdt.ui#951 and eclipse-jdt/eclipse.jdt.core#1663.

Could that be the trigger here?

[iloveeclipse]

I saw also some mails about 4.30 platform deploying artifacts to maven - that is the root cause may be?

[akurtakov]

I wonder if something in JDT has changed to cause new problems

There were changes in maven build like eclipse-jdt/eclipse.jdt.ui#951 and eclipse-jdt/eclipse.jdt.core#1663.

Could that be the trigger here?

IMHO, it's highly unlikely these to have caused it.

[laeubi]

I suspect that the JDT artifacts maybe include a pom information that confuses the license tool. I already noted in the past that the assumption that:

1. everything that has maven GAV is on central
2. everything that seem p2 is on orbit

in the tool is probably wrong.

[laeubi]

@akurtakov at laest from a short review the group ID of some items has changed e.g a feature previously had

<groupId>org.eclipse.jdt.feature</groupId>
<artifactId>org.eclipse.jdt.astview.feature</artifactId>

now will have

<groupId>org.eclipse.jdt.ui</groupId>
<artifactId>org.eclipse.jdt.astview.feature</artifactId>

(as one can also see on the screenshot).

So I think the license database has to be updated or one needs to restore the group id with this:

https://github.com/eclipse-tycho/tycho/wiki/Tycho-Pomless#overwrite-group-and-artifact-ids

/CC @vogella

[vogella]

So shall we restore the old IDs?

[akurtakov]

I suspect that the JDT artifacts maybe include a pom information that confuses the license tool. I already noted in the past that the assumption that:

1. everything that has maven GAV is on central

2. everything that seem p2 is on orbit

in the tool is probably wrong.

@laeubi have you raised these concerns in https://github.com/eclipse/dash-licenses/ ? The link to the issue would help for future references as the groupIds we have and are pushed to maven central mismatch and etc.

[akurtakov]

So shall we restore the old IDs?

Yes for now to unblock builds.

[vogella]

eclipse-jdt/eclipse.jdt.ui#965

[vogella]

eclipse-jdt/eclipse.jdt.debug#359

[vogella]

FYI - Both changes from above have been merged by @akurtakov

[akurtakov]

I'll trigger new I-build as otherwise all licensecheck usages would have to be changed to use master of the git submodules.

[merks]

🥳 The license checks pass!