Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show threads involved in disposing of components #1316

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Show threads involved in disposing of components #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...g.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/BundleComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ public void dispose() {
synchronized (this) {
fManifest = null;
fBundleDescription = null;
disposeSource = new RuntimeException("Component was disposed here"); //$NON-NLS-1$
String message = String.format("Component was disposed here [%s]", Thread.currentThread().getName()); //$NON-NLS-1$
disposeSource = new RuntimeException(message);
}
}
}
Expand Down Expand Up @@ -1202,7 +1203,9 @@ public ResolverError[] getErrors() throws CoreException {
*/
protected void baselineDisposed(IApiBaseline baseline) throws CoreException {
throw new CoreException(new Status(IStatus.ERROR, ApiPlugin.PLUGIN_ID, ApiPlugin.REPORT_BASELINE_IS_DISPOSED,
NLS.bind(Messages.BundleApiComponent_baseline_disposed, getName(), baseline.getName()), disposeSource));
NLS.bind(Messages.BundleApiComponent_baseline_disposed,
new Object[] { getName(), baseline.getName(), Thread.currentThread().getName() }),
disposeSource));
}

/*
Expand Down
2 changes: 1 addition & 1 deletion ...rg.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/model/Messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ApiType_1=Unable to resolve superclass {0} for {1}
ApiType_2=Unsupported operation - API component required for resolution
ApiType_3=Unable to resolve member type {0} for {1}
ApiScope_0=Unable to visit this element type: {0}
BundleApiComponent_baseline_disposed=Component ''{0}'' in the baseline ''{1}'' is disposed
BundleApiComponent_baseline_disposed=Component ''{0}'' in the baseline ''{1}'' is disposed [{2}]
BundleComponent_failed_to_lookup_fragment=Failed to look up resolved fragment: {0}
configuring_baseline=Configuring baseline
resolving_target_definition=resolving target definition...
Expand Down
Loading