-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org.eclipse.pde.api.tools.builder.tests.compatibility.BundleVersionTests "the baseline 'workspace' is disposed" #553
Comments
Sadly BundleVersionTests fails very frequently on verification builds. Could not reproduce locally on WIN. Also all calls of dispose() / getBundleDescription() during that Tests happen in the same Thread so that it probably is not an concurrency issue. |
fails on I Build too:
|
I think the error reporting is a bit odd here because it claims the baseline is disposed when
|
Currently BundleComponent do not propagate errors but only log them, this can lead to a situation where it is unclear what calls fails. This changes the init method to throw an CoreException in all cases where it encounters a problem and instead use dedicated catch whenever it seems suitable. See eclipse-pde#553
Currently BundleComponent do not propagate errors but only log them, this can lead to a situation where it is unclear what calls fails. This changes the init method to throw an CoreException in all cases where it encounters a problem and instead use dedicated catch whenever it seems suitable. See eclipse-pde#553
Currently BundleComponent do not propagate errors but only log them, this can lead to a situation where it is unclear what calls fails. This changes the init method to throw an CoreException in all cases where it encounters a problem and instead use dedicated catch whenever it seems suitable. See #553
I have now enhanced error reporting here: it shows that init is successful but it seems the component is unluckily dispose at this place already:
The synchronization is at least arguable here and seem to trying to perform premature optimization, beside that of course a component can be disposed anywhere anytime even after that so I'm a bit unsure how to handel this correctly if one has already fetched the component and it is then gone afterwards... |
This should hopefully be fixed by My understanding of the issue is the following:
I now did the following:
|
still happens:
https://github.com/eclipse-pde/eclipse.pde/actions/runs/9384000184/job/25838861125?pr=1290 |
The disposed error still happens but not in BundleVersionTests. The remaining error is tracked in |
Sometimes the test fails with
The text was updated successfully, but these errors were encountered: