Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 558835 LIC Execute feature must have it's own branding plug-in #99

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

eparovyshnaya
Copy link
Contributor

  • invite new org.eclipse.passage.lic.execute.branding plug-in
  • connect it to lic.execute.feature as branding plugin

Signed-off-by: elena.parovyshnaya [email protected]

- invite new `org.eclipse.passage.lic.execute.branding` plug-in

Signed-off-by: elena.parovyshnaya <[email protected]>
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use OSGI style for localization

@ruspl-afed
Copy link
Contributor

Nope, LOL

- invite new `org.eclipse.passage.lic.execute.branding` plug-in

Signed-off-by: elena.parovyshnaya <[email protected]>
@@ -16,6 +16,7 @@
label="%featureName"
version="0.8.0.qualifier"
provider-name="%providerName"
plugin="org.eclipse.passage.execute.branding"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update year in the header

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #99   +/-   ##
========================================
  Coverage      9.58%   9.58%           
  Complexity      103     103           
========================================
  Files           418     418           
  Lines         12745   12745           
  Branches       1103    1103           
========================================
  Hits           1221    1221           
  Misses        11488   11488           
  Partials         36      36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fa98b...fc25aef. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 4954a3a into eclipse-passage:master Jan 7, 2020
@eparovyshnaya
Copy link
Contributor Author

Resolves 558835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants