-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 558835 LIC Execute feature must have it's own branding plug-in #99
Conversation
- invite new `org.eclipse.passage.lic.execute.branding` plug-in Signed-off-by: elena.parovyshnaya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use OSGI style for localization
bundles/org.eclipse.passage.lic.execute.branding/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
Nope, LOL |
- invite new `org.eclipse.passage.lic.execute.branding` plug-in Signed-off-by: elena.parovyshnaya <[email protected]>
@@ -16,6 +16,7 @@ | |||
label="%featureName" | |||
version="0.8.0.qualifier" | |||
provider-name="%providerName" | |||
plugin="org.eclipse.passage.execute.branding" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update year in the header
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
========================================
Coverage 9.58% 9.58%
Complexity 103 103
========================================
Files 418 418
Lines 12745 12745
Branches 1103 1103
========================================
Hits 1221 1221
Misses 11488 11488
Partials 36 36 Continue to review full report at Codecov.
|
Resolves 558835 |
org.eclipse.passage.lic.execute.branding
plug-inlic.execute.feature
as branding pluginSigned-off-by: elena.parovyshnaya [email protected]