575181 expose License Agreements #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sum examination certificates properly: include agreements Signed-off-by: eparovyshnaya <[email protected]>
- Extract Trouble explanation for reuse - Extend Certificate explanation with agreements state description Signed-off-by: eparovyshnaya <[email protected]>
Enhance diagnostic for the severe-troubles-on-startup case Signed-off-by: eparovyshnaya <[email protected]>
Persist accepted agreement with base64-encoded-hash name, not naked hash Signed-off-by: eparovyshnaya <[email protected]>
fix 'worth attention" predicate: is must plainly depend on 'is restrictive', as it encloses non-trivial logic already. Signed-off-by: eparovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
=========================================
Coverage 33.64% 33.65%
Complexity 345 345
=========================================
Files 1106 1107 +1
Lines 24617 24643 +26
Branches 1528 1530 +2
=========================================
+ Hits 8283 8293 +10
- Misses 15846 15862 +16
Partials 488 488
Continue to review full report at Codecov.
|
ruspl-afed
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 'license agreement axposure' workable from
LicenseStatusDialog