575181 expose License Agreements on license import #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invite trouble code for the case when an agreement is discovered which has not yet been actively accepted by an end user - remove a copy of BaseAcceptenceCertificate class Signed-off-by: eparovyshnaya <[email protected]>
start implementing agreements assessment on access cycle run Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya
added
the
pr::wip
- implement product license state assessment - remove clones of BaseAccessCycleConfiguration as now 'lic.execute' provides one Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
reviewed
Aug 21, 2021
....eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/requirements/ResolvedAgreement.java
Show resolved
Hide resolved
....eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/requirements/ResolvedAgreement.java
Show resolved
Hide resolved
...rg.eclipse.passage.lic.emf/src/org/eclipse/passage/lic/emf/xmi/MigratingResourceHandler.java
Show resolved
Hide resolved
- Evolve Licensing Certificate structure with the result of requirement-resident agreements assessment. - Extend LicenseStatusDialog with the 'expose to accept' functionality Signed-off-by: eparovyshnaya <[email protected]>
- fix tests according to data structure evolution - fix agreement-from-requirement resolution according to test results Signed-off-by: eparovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
Coverage 33.63% 33.64%
+ Complexity 346 345 -1
==========================================
Files 1099 1106 +7
Lines 24474 24617 +143
Branches 1520 1528 +8
==========================================
+ Hits 8233 8283 +50
- Misses 15754 15846 +92
- Partials 487 488 +1
Continue to review full report at Codecov.
|
ruspl-afed
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lic.api.requirementinterfaces are extended with product agreements support:Requirementsupplies list ofResolvedAgreementslic.api.restrictionq interfaces are extended to deliver agreement asessment result withExaminationCertificate` as the result of access cycle runlic.jfacefacilities are replenished withAgreementsWizard, which currently exposes agreements of plan/text mime type to an end user and allows them to perform active acceptance.AgreementsWizardis plugged toLicenseStatusDialogas one of the intentions.