575166 License Agreement management: license issuing #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eparovyshnaya
commented
Aug 16, 2021
eparovyshnaya
commented
- pack AgreementData, supplied by LicensePlan, to PersonalLicensePack
- supply default string-list editor stub for LicensePlan:agreements collection
pack AgreementData, supplied by LicensePlan, to LicensePack Signed-off-by: eparovyshnaya <[email protected]>
management supply default string-list editor stub for LicensePlan:agreements collection Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
requested changes
Aug 16, 2021
...es.core/src/org/eclipse/passage/loc/licenses/trouble/code/LicenseAgreementsAttachFailed.java
Outdated
Show resolved
Hide resolved
....loc.licenses.core/src/org/eclipse/passage/loc/internal/licenses/core/LiecnseAgreements.java
Outdated
Show resolved
Hide resolved
management fix typo in class name fit copyright header Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
approved these changes
Aug 16, 2021
management fix typo in class name Signed-off-by: eparovyshnaya <[email protected]>
eparovyshnaya
changed the title
management bump minor version as LicensePlan editor grew one more field Signed-off-by: eparovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
============================================
- Coverage 33.65% 33.58% -0.08%
Complexity 346 346
============================================
Files 1094 1096 +2
Lines 24373 24425 +52
Branches 1515 1518 +3
============================================
Hits 8203 8203
- Misses 15683 15735 +52
Partials 487 487
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.