Bug 575166 License Agreement management: license issuing #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roll back FeatureVersion.agreements reference addition. Product-related agreements cannot be associated with FeatureVersion in order to be implanted to an issued license: one of base Passage use cases is to update a separate feature (install newer version, probably with new set of Agreements) in scope of an old license (version range allows). It is decided to protect Requirement gathering with product-related agreements. Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
requested changes
Aug 15, 2021
...s.model/src-gen/org/eclipse/passage/lic/features/model/util/FeaturesResourceFactoryImpl.java
Outdated
Show resolved
Hide resolved
...features.model/src-gen/org/eclipse/passage/lic/features/model/util/FeaturesResourceImpl.java
Outdated
Show resolved
Hide resolved
Keep versions Signed-off-by: eparovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
============================================
+ Coverage 33.66% 33.67% +0.01%
Complexity 346 346
============================================
Files 1094 1094
Lines 24372 24345 -27
Branches 1515 1514 -1
============================================
- Hits 8204 8198 -6
+ Misses 15681 15660 -21
Partials 487 487
Continue to review full report at Codecov.
|
ruspl-afed
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll back FeatureVersion.agreements reference addition.
Product-related agreements cannot be associated with FeatureVersion in
order to be implanted to an issued license: one of base Passage use
cases is to update a separate feature (install newer version, probably
with new set of Agreements) in scope of an old license (version range
allows). It is decided to protect Requirement gathering with
product-related agreements.
Signed-off-by: eparovyshnaya [email protected]