Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

558587 implement parametrized customer export #87

Merged
merged 6 commits into from
Dec 29, 2019
Merged

558587 implement parametrized customer export #87

merged 6 commits into from
Dec 29, 2019

Conversation

eparovyshnaya
Copy link
Contributor

Bug 558587 implement parametrized customer export

  • implement csv export command for "product(s) customers" scenario - based on yars.api
  • create a success-test for "product(s) customers" csv export command

Signed-off-by: elena.parovyshnaya [email protected]

implement csv export command for "product(s) customers" scenario

Signed-off-by: elena.parovyshnaya <[email protected]>
test for "product(s) customers" csv export command

Signed-off-by: elena.parovyshnaya <[email protected]>
append `org.eclipse.osgi.services` bundle directly to dependencies list

Signed-off-by: elena.parovyshnaya <[email protected]>
upgrade the test to `integration-like` one

Signed-off-by: elena.parovyshnaya <[email protected]>
 - redesign `report.core` to extract precise csv export command
functionality from OSGi components declarations
 - turn the test back to plain unit test style and focus on
OSGi-independent part verification

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #87 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #87      +/-   ##
===========================================
- Coverage      9.64%   9.57%   -0.08%     
  Complexity      103     103              
===========================================
  Files           408     419      +11     
  Lines         12653   12751      +98     
  Branches       1102    1103       +1     
===========================================
  Hits           1221    1221              
- Misses        11396   11494      +98     
  Partials         36      36
Impacted Files Coverage Δ Complexity Δ
...pse/passage/loc/report/internal/core/Messages.java 0% <ø> (ø) 0 <0> (?)
...sage/loc/report/internal/core/ProductCustomer.java 0% <ø> (ø) 0 <0> (?)
...passage/loc/report/internal/core/ProductNames.java 0% <ø> (ø) 0 <0> (?)
...se/passage/loc/report/internal/core/Customers.java 0% <0%> (ø) 0 <0> (?)
...oc/report/internal/core/ProductCustomersToCsv.java 0% <0%> (ø) 0 <0> (?)
...e/loc/report/internal/core/ExistingFileStream.java 0% <0%> (ø) 0 <0> (?)
...age/loc/report/internal/core/CsvExportService.java 0% <0%> (ø) 0 <0> (?)
...ssage/loc/report/internal/core/CustomersFetch.java 0% <0%> (ø) 0 <0> (?)
...se/passage/loc/report/internal/core/InnerData.java 0% <0%> (ø) 0 <0> (?)
.../eclipse/passage/loc/report/internal/core/Csv.java 0% <0%> (ø) 0 <0> (?)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a314e7...b523b66. Read the comment docs.

 - take care of csv stream encoding (UTF-8)

Signed-off-by: elena.parovyshnaya <[email protected]>
@ruspl-afed ruspl-afed merged commit f59caae into eclipse-passage:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants