Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 572650 - upgrade licenses domain model #774

Merged
merged 11 commits into from
May 16, 2021
Merged

Bug 572650 - upgrade licenses domain model #774

merged 11 commits into from
May 16, 2021

Conversation

eparovyshnaya
Copy link
Contributor

  • regenerate Model and Edit code for 'licenses' domain
  • fix the relying code

The following changes to model have been done:

  • LicensePack -> PersonalLicensePack
  • LicensePack.identifier -> PersonalLicensePack.license.identifier
  • LicensePack.issueDate -> PersonalLicensePack.license.issueDate
  • LicensePack.planIdentifier -> PersonalLicensePack.license.plan
  • LicensePack.productIdentifier -> PersonalLicensePack.license.product.identifier
  • LicensePack.productVersion -> PersonalLicensePack.license.product.version
  • LicensePack.requestIdentifier -> [deleted as it doubles pack.identifier and practically is not used by its own]
  • LicensePack.userIdentifier -> PersonalLicensePack.license.user.identifier
  • LicensePack.userFullName -> PersonalLicensePack.license.user.name
  • LicensePack.licenseGrants -> PersonalLicensePack.grants

Signed-off-by: eparovyshnaya [email protected]

eparovyshnaya and others added 10 commits May 13, 2021 21:47
- regenerate Model and Edit code for 'licenses' domain
- fix the relying code

Signed-off-by: eparovyshnaya <[email protected]>
reissue test floating license

Signed-off-by: eparovyshnaya <[email protected]>
Bump service version for affected bundle

Signed-off-by: eparovyshnaya <[email protected]>
Use Resource as an input

Signed-off-by: Alexander Fedorov <[email protected]>
Add migration functionality for licenses package

Signed-off-by: eparovyshnaya <[email protected]>
BaseXmiConditionTransport should use LicensesResourceImpl

Signed-off-by: eparovyshnaya <[email protected]>
- evolve LicResourceHandler to read legacy licenses
- extend test coverage

Signed-off-by: eparovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed May 16, 2021 15:48
@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #774 (05647e3) into master (6ff2803) will increase coverage by 2.01%.
The diff coverage is 45.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #774      +/-   ##
============================================
+ Coverage     31.51%   33.52%   +2.01%     
  Complexity      346      346              
============================================
  Files          1010     1021      +11     
  Lines         21174    21403     +229     
  Branches       1232     1261      +29     
============================================
+ Hits           6672     7175     +503     
+ Misses        14125    13823     -302     
- Partials        377      405      +28     
Impacted Files Coverage Δ Complexity Δ
...pse/passage/lbc/internal/base/mine/Conditions.java 73.91% <ø> (+73.91%) 0.00 <0.00> (ø)
...lic/internal/emf/migration/DelegatingEPackage.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...internal/licenses/e4/ui/LicensesE4UiProcessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...icenses/edit/providers/CompanyRefItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...oviders/FloatingLicenseRequisitesItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...censes/edit/providers/LicensePlanItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../providers/LicensesItemProviderAdapterFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...dit/providers/PersonalLicensePackItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...oviders/PersonalLicenseRequisitesItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/licenses/edit/providers/UserRefItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff2803...05647e3. Read the comment docs.

- evolve test coverage for license grants reading

Signed-off-by: eparovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya merged commit 2ae25d7 into master May 16, 2021
@eparovyshnaya eparovyshnaya deleted the 572650-6 branch May 17, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants