Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 572650 upgrade licenses domain model #772

Merged
merged 4 commits into from
May 12, 2021
Merged

Bug 572650 upgrade licenses domain model #772

merged 4 commits into from
May 12, 2021

Conversation

eparovyshnaya
Copy link
Contributor

@eparovyshnaya eparovyshnaya commented May 12, 2021

  • invite descriptors for floating license particles
  • evolve personal license particles descriptors: substitute Iterables with Lists

Signed-off-by: eparovyshnaya [email protected]

- invite descriptors for floating license particles
- evolve personal license particles descriptors: substitute 'Iterable's
with 'List's

Signed-off-by: eparovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed May 12, 2021 13:03
- evolve personal license particles descriptors: substitute 'Iterable's
with 'List's

Signed-off-by: eparovyshnaya <[email protected]>
- inherit floating license particles from the corresponding descriptors
- regenrate model and edit code

Signed-off-by: eparovyshnaya <[email protected]>
fix other implementations of the descriptors

Signed-off-by: eparovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #772 (3cc3bcb) into master (4e9f1cb) will decrease coverage by 3.89%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #772      +/-   ##
============================================
- Coverage     35.10%   31.20%   -3.90%     
  Complexity      346      346              
============================================
  Files          1015     1015              
  Lines         21620    21716      +96     
  Branches       1271     1283      +12     
============================================
- Hits           7589     6777     -812     
- Misses        13633    14558     +925     
+ Partials        398      381      -17     
Impacted Files Coverage Δ Complexity Δ
...sage/lic/licenses/model/impl/LicenseGrantImpl.java 40.00% <ø> (ø) 0.00 <0.00> (ø)
...ic/licenses/model/impl/LicensePlanFeatureImpl.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ssage/lic/licenses/model/impl/LicensePlanImpl.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...e/lic/licenses/model/impl/LicensesFactoryImpl.java 73.43% <ø> (ø) 0.00 <0.00> (ø)
...ssage/lic/licenses/model/meta/LicensesFactory.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ssage/lic/licenses/model/meta/LicensesPackage.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ic/licenses/model/util/LicensesAdapterFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../lic/licenses/model/util/LicensesResourceImpl.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...assage/lic/licenses/model/util/LicensesSwitch.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ssage/lic/licenses/model/impl/LicensePackImpl.java 47.36% <60.00%> (ø) 0.00 <0.00> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9f1cb...3cc3bcb. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 81065ce into master May 12, 2021
@eparovyshnaya eparovyshnaya deleted the 572650-5 branch May 17, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants