Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 573296 - [Passage] rework EMF migration facilities #758

Merged
merged 3 commits into from
May 1, 2021
Merged

Conversation

ruspl-afed
Copy link
Contributor

Extract "ExtractResource"

Signed-off-by: Alexander Fedorov [email protected]

ruspl-afed added 2 commits May 1, 2021 11:16
Extract "ExtractResource"

Signed-off-by: Alexander Fedorov <[email protected]>
Extract "ExtractEObject"

Signed-off-by: Alexander Fedorov <[email protected]>
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #758 (7925036) into master (e63ec08) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 7925036 differs from pull request most recent head 89b502b. Consider uploading reports for the commit 89b502b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #758      +/-   ##
============================================
- Coverage     34.98%   34.97%   -0.01%     
  Complexity      346      346              
============================================
  Files           995      997       +2     
  Lines         21385    21393       +8     
  Branches       1271     1270       -1     
============================================
+ Hits           7481     7483       +2     
- Misses        13501    13508       +7     
+ Partials        403      402       -1     
Impacted Files Coverage Δ Complexity Δ
.../eclipse/passage/lic/emf/ecore/ExtractEObject.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eclipse/passage/lic/emf/ecore/ExtractResource.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../eclipse/passage/lic/emf/ecore/LicensingEcore.java 16.21% <ø> (+4.45%) 0.00 <0.00> (ø)
...sage/loc/workbench/emfforms/parts/DetailsView.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/internal/base/acquire/AcquiredGrantsStorage.java 100.00% <0.00%> (+2.70%) 0.00% <0.00%> (ø%)
...e/passage/lic/internal/bc/BcResidentSecretKey.java 95.65% <0.00%> (+4.34%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63ec08...89b502b. Read the comment docs.

extract "resource" package and switch to 2.0.0

Signed-off-by: Alexander Fedorov <[email protected]>
@ruspl-afed ruspl-afed requested a review from eparovyshnaya May 1, 2021 08:41
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static utils are nicely eliminated, llllove it!

@ruspl-afed ruspl-afed merged commit 44b1c7d into master May 1, 2021
@eparovyshnaya eparovyshnaya deleted the 573296 branch May 8, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants