572833 #741
Merged
572833 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eparovyshnaya
commented
Apr 17, 2021
eparovyshnaya
commented
- refine feature identifiers and locate them properly
- evolve LicensedRunnable: let it handle rejection case, should the need arise
Move licensing requirements for issuing-related features to 'loc.api' as there the corresponding functionality declaration reside Signed-off-by: eparovyshnaya <[email protected]>
Let Licensed Runnable handle rejection case as well Signed-off-by: eparovyshnaya <[email protected]>
Refine issuing features' identifiers Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
reviewed
Apr 17, 2021
...passage.lic.jface/src/org/eclipse/passage/lic/internal/jface/actions/LicensedRunnableUi.java
Outdated
Show resolved
Hide resolved
Fix formatting Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
approved these changes
Apr 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
============================================
- Coverage 36.23% 36.21% -0.03%
Complexity 346 346
============================================
Files 957 957
Lines 20632 20643 +11
Branches 1233 1233
============================================
- Hits 7476 7475 -1
- Misses 12754 12766 +12
Partials 402 402
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.