Bug 571526 open license folder after issuing #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'open folder' to the final notification dialog Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
reviewed
Apr 9, 2021
...dashboard.ui/src/org/eclipse/passage/loc/dashboard/ui/wizards/LicenseIssuedNotification.java
Show resolved
Hide resolved
...dashboard.ui/src/org/eclipse/passage/loc/dashboard/ui/wizards/LicenseIssuedNotification.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
============================================
- Coverage 36.66% 36.62% -0.04%
Complexity 346 346
============================================
Files 942 943 +1
Lines 20104 20128 +24
Branches 1195 1195
============================================
+ Hits 7371 7372 +1
- Misses 12331 12355 +24
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
Use eclipse.swt.Program facility instead of java.awt.Desktop to open a folder. Signed-off-by: eparovyshnaya <[email protected]>
ruspl-afed
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'open folder' to the final notification dialog
Signed-off-by: eparovyshnaya [email protected]