# 553807 - revise permission observatory API #72
Conversation
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
===========================================
+ Coverage 9.54% 9.67% +0.13%
- Complexity 98 103 +5
===========================================
Files 401 403 +2
Lines 12598 12618 +20
Branches 1102 1102
===========================================
+ Hits 1202 1221 +19
- Misses 11360 11361 +1
Partials 36 36
Continue to review full report at Codecov.
|
...lic.base/src/org/eclipse/passage/lic/internal/base/permission/observatory/CheckSchedule.java
Outdated
Show resolved
Hide resolved
...lic.base/src/org/eclipse/passage/lic/internal/base/permission/observatory/CheckSchedule.java
Outdated
Show resolved
Hide resolved
...lic.base/src/org/eclipse/passage/lic/internal/base/permission/observatory/CheckSchedule.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Default schedule is 10 minutes. | ||
| * | ||
| * @since 1.6.1 |
There was a problem hiding this comment.
we do not have version 1.6.1
...lic.base/src/org/eclipse/passage/lic/internal/base/permission/observatory/CheckSchedule.java
Outdated
Show resolved
Hide resolved
| * expired entries each 5 minutes (or so). | ||
| * </p> | ||
| * | ||
| * @since 0.6.1 |
There was a problem hiding this comment.
Normally "since" tag value has only major.minor form
| * | ||
| * @param amount number of units | ||
| * @unit {@linkplain ChronoUnit} constant to measure {@code amount} | ||
| * @since 0.6.1 |
There was a problem hiding this comment.
Normally "since" tag value has only major.minor form
| * Default schedules are measured in minutes. | ||
| * | ||
| * @param minutes number of minutes | ||
| * @since 0.6.1 |
There was a problem hiding this comment.
Normally "since" tag value has only major.minor form
| /** | ||
| * Reports the scheduled period duration in seconds. | ||
| * | ||
| * @since 0.6.1 |
There was a problem hiding this comment.
Normally "since" tag value has only major.minor form
| /** | ||
| * Default schedule is 10 minutes. | ||
| * | ||
| * @since 0.6.1 |
There was a problem hiding this comment.
Normally "since" tag value has only major.minor form
There was a problem hiding this comment.
Does this mean, it can be not equal to current bundle version? Must simple 0.6 appear there?
There was a problem hiding this comment.
Exactly. API may not be added with service release, only with minor one. So, the "0.6.1" is "0.6"
There was a problem hiding this comment.
Does this mean we must mention since-version only on public apis? (which is not ther case here)
- Observatory is renamed to Pool - GuardedObservatory is renamed to Observatory - schedule semantics is formed to a separate class - which is, in turn, covered with tests Signed-off-by: elena.parovyshnaya <[email protected]>
Signed-off-by: elena.parovyshnaya [email protected]