Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

572623 redesign license containment #713

Merged
merged 14 commits into from
Apr 7, 2021
Merged

572623 redesign license containment #713

merged 14 commits into from
Apr 7, 2021

Conversation

eparovyshnaya
Copy link
Contributor

port all entities from floating domain into licenses

Increment `licenses` model version as the content is replenished: 1.0.0
-> 1.1.0

Signed-off-by: eparovyshnaya <[email protected]>
Evolve genmodel accordingly

Signed-off-by: eparovyshnaya <[email protected]>
Regenerate model code for amended model

Signed-off-by: eparovyshnaya <[email protected]>
Regenerate edit code for amended model

Signed-off-by: eparovyshnaya <[email protected]>
Suspend major version upgrade demands

Signed-off-by: eparovyshnaya <[email protected]>
Suspend major version upgrade demands

Signed-off-by: eparovyshnaya <[email protected]>
Bump service version for touched bundle

Signed-off-by: eparovyshnaya <[email protected]>
Bump service version for affected feature

Signed-off-by: eparovyshnaya <[email protected]>
Bump service version for affected feature

Signed-off-by: eparovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed April 7, 2021 06:04
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good in general Please take care about failing test

Update version of dependencies for 'lic.licenses.model'

Signed-off-by: eparovyshnaya <[email protected]>
Bump service version for amended bundle

Signed-off-by: eparovyshnaya <[email protected]>
Migrate '1.0.0'-based licenses to '1.1.0'

Signed-off-by: eparovyshnaya <[email protected]>
Update license header

Signed-off-by: eparovyshnaya <[email protected]>
Bump service version for affected bundle

Signed-off-by: eparovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #713 (19f7f86) into master (0165a07) will decrease coverage by 2.10%.
The diff coverage is 14.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #713      +/-   ##
============================================
- Coverage     35.59%   33.48%   -2.11%     
  Complexity      346      346              
============================================
  Files           970      994      +24     
  Lines         20732    22856    +2124     
  Branches       1233     1419     +186     
============================================
+ Hits           7379     7654     +275     
- Misses        12945    14795    +1850     
+ Partials        408      407       -1     
Impacted Files Coverage Δ Complexity Δ
.../providers/EvaluationInstructionsItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...enses/edit/providers/FeatureGrantItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...t/providers/FloatingLicenseAccessItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...dit/providers/FloatingLicensePackItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...roviders/FloatingServerConnectionItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ses/edit/providers/FloatingServerItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...es/edit/providers/GrantAcqisitionItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...enses/edit/providers/LicenseGrantItemProvider.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...censes/edit/providers/LicensePlanItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../edit/providers/LicenseRequisitesItemProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0165a07...19f7f86. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 4113509 into master Apr 7, 2021
@eparovyshnaya eparovyshnaya deleted the 572623 branch April 8, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants