Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

553629 lic.base - avoid dependency from OSGi FrameworkUtil #70

Merged
merged 1 commit into from
Nov 30, 2019
Merged

553629 lic.base - avoid dependency from OSGi FrameworkUtil #70

merged 1 commit into from
Nov 30, 2019

Conversation

eparovyshnaya
Copy link
Contributor

  • Class.getName() is used instead of a bundle symbolic name
  • OSGi dependency is eliminated from lic.base

Signed-off-by: elena.parovyshnaya [email protected]

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.23%.
The diff coverage is 86.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #70      +/-   ##
===========================================
+ Coverage       9.3%   9.54%   +0.23%     
- Complexity       86      98      +12     
===========================================
  Files           400     401       +1     
  Lines         12565   12598      +33     
  Branches       1100    1102       +2     
===========================================
+ Hits           1169    1202      +33     
+ Misses        11363   11360       -3     
- Partials         33      36       +3
Impacted Files Coverage Δ Complexity Δ
...org/eclipse/passage/lic/base/LicensingResults.java 58.97% <0%> (+6.47%) 0 <0> (ø) ⬇️
...e/passage/lic/base/tests/LicensingResultsTest.java 91.17% <91.17%> (ø) 12 <12> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5725b...31825ef. Read the comment docs.

 - class.getName() is used instead of a bundle symbolic name
 - dependency is eliminated
 - test suite is created


Signed-off-by: elena.parovyshnaya <[email protected]>
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix it for 0.7.0

@eparovyshnaya eparovyshnaya merged commit 91197fd into eclipse-passage:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants