Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 572366 verify product's public key on hc-fls interaction #696

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

eparovyshnaya
Copy link
Contributor

  • add 'algo' parameter to all HC requests for the server to be aware of encoding applied
  • read the parameter for all net request handlers

Signed-off-by: eparovyshnaya [email protected]

Add 'algo' parameter to all HC requests for the server to be aware of
encoding applied.

Read the parameter for all net request handlers.

Signed-off-by: eparovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #696 (2c69e83) into master (bc5d5b8) will increase coverage by 0.03%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #696      +/-   ##
============================================
+ Coverage     36.04%   36.08%   +0.03%     
  Complexity      339      339              
============================================
  Files           941      942       +1     
  Lines         19993    20004      +11     
  Branches       1192     1192              
============================================
+ Hits           7207     7218      +11     
  Misses        12384    12384              
  Partials        402      402              
Impacted Files Coverage Δ Complexity Δ
...ge/lic/internal/net/handle/ProductUserRequest.java 94.73% <66.66%> (-5.27%) 0.00 <0.00> (ø)
...lic/internal/hc/remote/impl/RequestParameters.java 92.59% <100.00%> (+0.92%) 0.00 <0.00> (ø)
.../remote/impl/acquire/AcquireRequestParameters.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
.../remote/impl/acquire/ReleaseRequestParameters.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...internal/hc/remote/impl/acquire/RemoteAcquire.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...internal/hc/remote/impl/acquire/RemoteRelease.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...nal/hc/remote/impl/mine/MineRequestParameters.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...l/hc/remote/impl/mine/RemoteConditionsRequest.java 75.00% <100.00%> (ø) 0.00 <0.00> (ø)
...se/passage/lic/internal/net/EncodingAlgorithm.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5d5b8...2c69e83. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit f55076b into master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants