Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 568589 - [Passage][Operator] provide an interactive welcome screen #537

Merged
merged 6 commits into from
Nov 12, 2020

Conversation

zelenyhleb
Copy link
Contributor

added intro bundle for eclipse 3.x

Signed-off-by: Nikifor Fedorov [email protected]

added intro bundle for eclipse 3.x

Signed-off-by: Nikifor Fedorov <[email protected]>
attempt to fix some codacy issues, added licenses where needed

Signed-off-by: Nikifor Fedorov <[email protected]>
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #537 (0f5de8a) into master (39acf1b) will decrease coverage by 0.49%.
The diff coverage is 15.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #537      +/-   ##
============================================
- Coverage     30.80%   30.30%   -0.50%     
- Complexity      258      264       +6     
============================================
  Files           815      860      +45     
  Lines         17769    18488     +719     
  Branches       1107     1129      +22     
============================================
+ Hits           5473     5603     +130     
- Misses        12062    12634     +572     
- Partials        234      251      +17     
Impacted Files Coverage Δ Complexity Δ
...eclipse/passage/lbc/internal/base/chains/Mine.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...lipse/passage/lbc/internal/jetty/JettyHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/eclipse/passage/lbc/json/JsonLoadedLicense.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...lic/internal/base/BaseServiceInvocationResult.java 93.10% <ø> (+6.00%) 0.00 <0.00> (ø)
...e/passage/lic/internal/base/FeatureIdentifier.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...lipse/passage/lic/internal/base/access/Assess.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/passage/lic/internal/base/access/Conditions.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...clipse/passage/lic/internal/base/access/Cycle.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...passage/lic/internal/base/access/Restrictions.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...l/base/conditions/mining/LicensingContentType.java 60.00% <ø> (ø) 0.00 <0.00> (ø)
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39acf1b...4569539. Read the comment docs.

other attempt to fix codacy issues

Signed-off-by: Nikifor Fedorov <[email protected]>
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just minor notes from me.

still trying to fix css styling

Signed-off-by: Nikifor Fedorov <[email protected]>
still trying to fix css styling

Signed-off-by: Nikifor Fedorov <[email protected]>
@eparovyshnaya eparovyshnaya merged commit 278b794 into master Nov 12, 2020
@eparovyshnaya eparovyshnaya deleted the 568589 branch November 12, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants