Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 568632 Implement feature grant acquire/release #536

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Conversation

eparovyshnaya
Copy link
Contributor

@eparovyshnaya eparovyshnaya commented Nov 9, 2020

Refactor lic.hc content:

  • separate condition mining specifics from the floating server communication common code.
  • move general net classes to lic.net.

Signed-off-by: eparovyshnaya [email protected]

Refactor lic.hc content: separate condition mining specifics from the
floating server communication common code.

Move general net classes to `lic.net`.

Signed-off-by: eparovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@17d1a33). Click here to learn what that means.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #536   +/-   ##
=========================================
  Coverage          ?   30.83%           
  Complexity        ?      269           
=========================================
  Files             ?      848           
  Lines             ?    18218           
  Branches          ?     1116           
=========================================
  Hits              ?     5617           
  Misses            ?    12350           
  Partials          ?      251           
Impacted Files Coverage Δ Complexity Δ
...e/passage/lic/internal/base/FeatureIdentifier.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/passage/lic/internal/hc/i18n/AccessMessages.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ssage/lic/internal/hc/remote/impl/AccessFiles.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ssage/lic/internal/hc/remote/impl/AccessPacks.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rnal/hc/remote/impl/FloatingServerCoordinates.java 100.00% <ø> (ø) 0.00 <0.00> (?)
...ernal/hc/remote/impl/mine/DecryptedConditions.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...nal/hc/remote/impl/mine/MineRequestParameters.java 100.00% <ø> (ø) 0.00 <0.00> (?)
...internal/hc/remote/impl/mine/RemoteConditions.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../eclipse/passage/lic/internal/net/LicenseUser.java 100.00% <ø> (ø) 0.00 <0.00> (?)
...c/internal/net/ServerAuthenticationExpression.java 100.00% <ø> (ø) 0.00 <0.00> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d1a33...6b14a2c. Read the comment docs.

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move from LIC HC to LIC Net looks good to me

@eparovyshnaya eparovyshnaya merged commit 8a9ccc4 into master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants