Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 567032 issue floating license configuration wizard #501

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

eparovyshnaya
Copy link
Contributor

Move Issue floating license dialog further, ready for ECP

Signed-off-by: eparovyshnaya [email protected]

Move Issue floating license dialog further, ready for ECP

Signed-off-by: eparovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #501 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
- Coverage     31.15%   31.07%   -0.08%     
  Complexity      279      279              
============================================
  Files           806      808       +2     
  Lines         17525    17563      +38     
  Branches       1093     1096       +3     
============================================
- Hits           5460     5458       -2     
- Misses        11831    11871      +40     
  Partials        234      234              
Impacted Files Coverage Δ Complexity Δ
...zards/floating/FloatingLicensePackConstructed.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...i/wizards/floating/IssueFloatingLicenseWizard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...oard/ui/wizards/floating/IssueLicensePackPage.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...d/ui/wizards/floating/IssueLicenseRequestPage.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...loc/dashboard/ui/wizards/license/ComposedPage.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../licenses/core/FloatingLicensePackFromRequest.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nal/licenses/core/request/FloatingLicenseData.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/passage/lic/internal/bc/BcResidentSecretKey.java 91.30% <0.00%> (-8.70%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506435d...21c5a01. Read the comment docs.

Update `licenses` emf forms according to meta-model version evolution

Signed-off-by: eparovyshnaya <[email protected]>
}
if (license != null) {
try {
ECPSWTViewRenderer.INSTANCE.render(base, license, properties);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each call will add more "license controls" to the base

@ruspl-afed ruspl-afed self-requested a review October 31, 2020 08:53
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that you do not call "render" more than once

@eparovyshnaya eparovyshnaya merged commit ab9f124 into master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants