Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 565012 - API revision | permission | OshiPermissionEmitter #307

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  1. Redesign hardware state reading synchronization in order to lock only reading code. Mutability of data structures in State are also eliminated, new instance of State is created for each request.
  2. Test the service, including massive simultaneous requests case.

Signed-off-by: elena.parovyshnaya [email protected]

 - Redesign hardware state reading synchronization in order to  `lock`
only reading code. Mutability of data structures in `State` are also
eliminated, new instance of `State` is created for each request.
 - Test the service, including massive simultaneous requests case.


Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 12, 2020 05:11
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #307 into master will increase coverage by 0.82%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   27.25%   28.07%   +0.82%     
==========================================
  Files         725      725              
  Lines       17008    17005       -3     
  Branches     1214     1214              
==========================================
+ Hits         4635     4774     +139     
+ Misses      12222    12078     -144     
- Partials      151      153       +2     
Impacted Files Coverage Δ
...c/internal/oshi/tobemoved/HardwareEnvironment.java 87.50% <80.00%> (+87.50%) ⬆️
...pse/passage/lic/internal/oshi/tobemoved/State.java 98.46% <100.00%> (+98.46%) ⬆️
...e/passage/lic/internal/bc/BcResidentSecretKey.java 91.30% <0.00%> (-8.70%) ⬇️
...c/internal/api/inspection/EnvironmentProperty.java 31.25% <0.00%> (+31.25%) ⬆️
...age/lic/internal/base/inspection/hardware/Cpu.java 85.71% <0.00%> (+85.71%) ⬆️
...sage/lic/internal/base/inspection/hardware/OS.java 100.00% <0.00%> (+100.00%) ⬆️
...ge/lic/internal/base/inspection/hardware/Disk.java 100.00% <0.00%> (+100.00%) ⬆️
...ic/internal/base/inspection/hardware/Computer.java 100.00% <0.00%> (+100.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ed583...0a1f9d8. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit d38cc6f into master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants