Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 565011 rebuild the core of condition expression evaluation #300

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

eparovyshnaya
Copy link
Contributor

complete test set for conditions.evaluation

Signed-off-by: elena.parovyshnaya [email protected]

 complete test set for `conditions.evaluation`

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 9, 2020 17:46
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #300 into master will increase coverage by 0.91%.
The diff coverage is 85.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   25.42%   26.33%   +0.91%     
==========================================
  Files         702      704       +2     
  Lines       16721    16815      +94     
  Branches     1212     1212              
==========================================
+ Hits         4251     4428     +177     
+ Misses      12336    12247      -89     
- Partials      134      140       +6     
Impacted Files Coverage Δ
...e/passage/lic/api/tests/FrameworkContractTest.java 0.00% <0.00%> (ø)
...ns/evaluation/FakeExpressionEvaluationService.java 0.00% <0.00%> (ø)
.../lic/api/tests/fakes/conditions/FakeCondition.java 60.00% <61.11%> (+40.00%) ⬆️
.../evaluation/BasePermissionEmittingServiceTest.java 90.27% <90.27%> (ø)
...se/tests/conditions/evaluation/BiasedAssessor.java 92.30% <92.30%> (ø)
...ions/evaluation/BasePermissionEmittingService.java 94.73% <100.00%> (+94.73%) ⬆️
...tion/SimpleMapExpressionEvaluationServiceTest.java 83.33% <100.00%> (+2.38%) ⬆️
...ssage/lic/internal/api/diagnostic/TroubleCode.java 57.14% <0.00%> (+7.14%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1979d63...8b73cd4. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit c2706be into master Jul 9, 2020
@eparovyshnaya eparovyshnaya deleted the 565011 branch July 9, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants