Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 565011 rebuild the core of condition expression evaluation #299

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

eparovyshnaya
Copy link
Contributor

Start covering conditions.evaluation with tests.

Signed-off-by: elena.parovyshnaya [email protected]

 Start covering `conditions.evaluation` with tests.

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 9, 2020 11:18
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #299 into master will increase coverage by 1.23%.
The diff coverage is 70.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   24.18%   25.42%   +1.23%     
==========================================
  Files         694      702       +8     
  Lines       16576    16721     +145     
  Branches     1210     1212       +2     
==========================================
+ Hits         4009     4251     +242     
+ Misses      12440    12336     -104     
- Partials      127      134       +7     
Impacted Files Coverage Δ
...c/internal/api/conditions/evaluation/Emission.java 100.00% <ø> (+100.00%) ⬆️
...ests/conditions/evaluation/BasePermissionTest.java 23.07% <23.07%> (ø)
...ation/ExpressionEvaluationServiceContractTest.java 25.00% <25.00%> (ø)
...aluation/ExpressionParsingServiceContractTest.java 58.33% <58.33%> (ø)
...uation/AndsProtocolExpressionParseServiceTest.java 70.83% <70.83%> (ø)
...tion/SimpleMapExpressionEvaluationServiceTest.java 80.95% <80.95%> (ø)
...ests/conditions/evaluation/SumOfEmissionsTest.java 82.60% <82.60%> (ø)
...ase/conditions/evaluation/SimpleMapExpression.java 100.00% <100.00%> (+100.00%) ⬆️
...aluation/SimpleMapExpressionEvaluationService.java 87.87% <100.00%> (+87.87%) ⬆️
...nditions/evaluation/EmissionImplsContractTest.java 100.00% <100.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb9af0...1979d63. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit d9ec680 into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants