Bug 565011 rebuild the core of condition expression evaluation #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement all `yet-to-be-done`-s in `lic.internal.conditions.evaluation` Signed-off-by: elena.parovyshnaya <[email protected]>
- evolve `api.fakes` - start testing `lic.internal.conditions.evaluation`. Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 24.30% 24.18% -0.13%
==========================================
Files 689 694 +5
Lines 16480 16576 +96
Branches 1201 1210 +9
==========================================
+ Hits 4006 4009 +3
- Misses 12347 12440 +93
Partials 127 127
Continue to review full report at Codecov.
|
ruspl-afed
requested changes
Jul 9, 2020
....base/src/org/eclipse/passage/lic/internal/base/i18n/ConditionsEvaluationMessages.properties
Outdated
Show resolved
Hide resolved
- reorder `.properties` file and fix a typo Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement all
yet-to-be-done-s inlic.internal.conditions.evaluationSigned-off-by: elena.parovyshnaya [email protected]