Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 565011 rebuild the core of condition expression evaluation #296

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  • extend AccessCycleConfiguration with newly designed service registries
  • implement extensions in sealed configuration
  • cover new facilities with tests in scope of FrameworkContractTest suite

Signed-off-by: elena.parovyshnaya [email protected]

 - extend `AccessCycleConfiguration` with newly designed service
registries
 - implement extensions in sealed configuration
 - cover new facilities with tests in scope of `FrameworkContractTest`
suite

Signed-off-by: elena.parovyshnaya <[email protected]>
 - extend `AccessCycleConfiguration` with newly designed service
registries
 - implement extensions in sealed configuration
 - cover new facilities with tests in scope of `FrameworkContractTest`
suite

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 8, 2020 16:29
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #296 into master will increase coverage by 11.45%.
The diff coverage is 19.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #296       +/-   ##
===========================================
+ Coverage   12.56%   24.02%   +11.45%     
===========================================
  Files         674      681        +7     
  Lines       16367    16437       +70     
  Branches     1199     1200        +1     
===========================================
+ Hits         2057     3949     +1892     
+ Misses      14258    12364     -1894     
- Partials       52      124       +72     
Impacted Files Coverage Δ
...e/passage/lic/api/tests/FrameworkContractTest.java 0.00% <0.00%> (ø)
...ts/conditions/evaluation/EmissionContractTest.java 0.00% <0.00%> (ø)
.../tests/fakes/FakeConditionExpressionEvaluator.java 0.00% <0.00%> (ø)
...api/tests/fakes/FakeConditionExpressionParser.java 0.00% <0.00%> (ø)
...ts/fakes/FakeExpressionTokenAssessmentService.java 0.00% <0.00%> (ø)
...al/base/tests/requirements/SabotagedFramework.java 40.00% <20.00%> (-14.55%) ⬇️
...ic/internal/api/registry/AggregativeServiceId.java 70.00% <70.00%> (ø)
...tions/evaluation/ExpressionFormatContractTest.java 100.00% <100.00%> (ø)
...sts/registry/AggregativeServiceIdContractTest.java 100.00% <100.00%> (ø)
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4145de...14f1b73. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit ea3e2b7 into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants