Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 565011 rebuild the core of condition expression evaluation #295

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

eparovyshnaya
Copy link
Contributor

Start implementing condition evaluation services. FIXME: ytbd entries mean further work (currently clear) to be done here.

Signed-off-by: elena.parovyshnaya [email protected]

 Start implementing condition evaluation services. `FIXME: ytbd` entries
mean further work (currently clear) to be done here.

 Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 8, 2020 12:48
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #295 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   12.65%   12.56%   -0.09%     
==========================================
  Files         666      674       +8     
  Lines       16254    16367     +113     
  Branches     1194     1199       +5     
==========================================
  Hits         2057     2057              
- Misses      14145    14258     +113     
  Partials       52       52              
Impacted Files Coverage Δ
...passage/lic/base/access/BasePermissionEmitter.java 47.36% <ø> (ø)
...evaluation/AndsProtocolExpressionParseService.java 0.00% <0.00%> (ø)
...ions/evaluation/BaseEmissionFailureDiagnostic.java 0.00% <0.00%> (ø)
...nal/base/conditions/evaluation/BasePermission.java 0.00% <0.00%> (ø)
...ions/evaluation/BasePermissionEmittingService.java 0.00% <0.00%> (ø)
...se/conditions/evaluation/FormalizedExpression.java 0.00% <0.00%> (ø)
...ase/conditions/evaluation/SimpleMapExpression.java 0.00% <0.00%> (ø)
...aluation/SimpleMapExpressionEvaluationService.java 0.00% <0.00%> (ø)
...nal/base/conditions/evaluation/SumOfEmissions.java 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9585c8...f4145de. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit a94bf24 into master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants