Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 565009 API revision | permission | rework key interfaces #293

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

eparovyshnaya
Copy link
Contributor

@eparovyshnaya eparovyshnaya commented Jul 7, 2020

Side work: explain Condition validity period in java.time.ZonedDateTime instead of util.Date.

Signed-off-by: elena.parovyshnaya [email protected]

  Side work: explain Condition validity period in
java.time.ZonedDateTime instead of util.Date.

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 7, 2020 16:52
  Side work: explain Condition validity period in
java.time.ZonedDateTime instead of util.Date.

Signed-off-by: elena.parovyshnaya <[email protected]>
  Side work: explain Condition validity period in
java.time.ZonedDateTime instead of util.Date.

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #293 into master will decrease coverage by 0.04%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   12.72%   12.67%   -0.05%     
==========================================
  Files         665      664       -1     
  Lines       16241    16232       -9     
  Branches     1194     1194              
==========================================
- Hits         2066     2057       -9     
  Misses      14123    14123              
  Partials       52       52              
Impacted Files Coverage Δ
...internal/json/tobemoved/ConditionDeserializer.java 0.00% <0.00%> (ø)
...c/internal/json/tobemoved/ConditionSerializer.java 0.00% <0.00%> (ø)
.../lic/internal/json/tobemoved/JsonObjectMapper.java 0.00% <ø> (ø)
...ses/migration/tobemoved/XmiConditionTransport.java 0.00% <0.00%> (ø)
...tests/conditions/BaseValidityPeriodClosedTest.java 20.00% <0.00%> (ø)
...tions/contract/BaseValidityPeriodContractTest.java 100.00% <ø> (ø)
...rnal/base/conditions/BaseValidityPeriodClosed.java 84.61% <66.66%> (ø)
...s/conditions/ValidityPeriodClosedContractTest.java 60.00% <66.66%> (-6.67%) ⬇️
...i/tests/conditions/ValidityPeriodContractTest.java 100.00% <100.00%> (ø)
...sts/conditions/ValidityPeriodOpenContractTest.java 80.00% <100.00%> (-8.24%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec19433...0d45215. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit cf62f6a into master Jul 8, 2020
@eparovyshnaya eparovyshnaya deleted the 565009 branch July 9, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants