Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

564986 API revision | conditions | transport | xml #291

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Conversation

eparovyshnaya
Copy link
Contributor

  • reduce ConditionTransport functionality to read only

Signed-off-by: elena.parovyshnaya [email protected]

 - reduce `ConditionTransport` functionality to `read` only

Signed-off-by: elena.parovyshnaya <[email protected]>
 - alter `ConditionTransport`'s documentation according to the
functionality reduction

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 7, 2020 07:17
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #291 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   12.71%   12.73%   +0.01%     
==========================================
  Files         664      664              
  Lines       16250    16229      -21     
  Branches     1196     1194       -2     
==========================================
  Hits         2066     2066              
+ Misses      14132    14111      -21     
  Partials       52       52              
Impacted Files Coverage Δ
...age/lic/internal/json/tobemoved/ConditionPack.java 0.00% <0.00%> (ø)
...nternal/json/tobemoved/JsonConditionTransport.java 0.00% <ø> (ø)
.../lic/internal/json/tobemoved/JsonObjectMapper.java 0.00% <0.00%> (ø)
...rnal/licenses/migration/XmiConditionTransport.java 0.00% <ø> (ø)
...ses/migration/tobemoved/XmiConditionTransport.java 0.00% <ø> (ø)
...ditions/mining/ConditionTransportContractTest.java 0.00% <0.00%> (ø)
...ge/lic/api/tests/fakes/FakeConditionTransport.java 0.00% <ø> (ø)
...ase/tests/conditions/mining/HeadOnlyTransport.java 100.00% <ø> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a873827...671e46f. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 9c72909 into master Jul 7, 2020
@eparovyshnaya eparovyshnaya deleted the 564986 branch July 9, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants