564818 API revision | conditions | key keepers review #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
side work: extend documentation Signed-off-by: elena.parovyshnaya <[email protected]>
- reimplement BundleKeykeeper over the new (1.0) interfaces - deprecate obsolete implementation Signed-off-by: elena.parovyshnaya <[email protected]>
- test set for BundleKeykeeper Signed-off-by: elena.parovyshnaya <[email protected]>
- plug BundleKeyKeeper service to the sealed framework Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 11.75% 11.73% -0.02%
==========================================
Files 645 646 +1
Lines 15904 15929 +25
Branches 1189 1190 +1
==========================================
Hits 1870 1870
- Misses 13986 14011 +25
Partials 48 48
Continue to review full report at Codecov.
|
ruspl-afed
requested changes
Jul 5, 2020
...age.lic.equinox/src/org/eclipse/passage/lic/internal/equinox/i18n/EquinoxMessages.properties
Outdated
Show resolved
Hide resolved
...age.lic.equinox/src/org/eclipse/passage/lic/internal/equinox/i18n/EquinoxMessages.properties
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public InputStream productPublicKey() throws LicensingException { | ||
| URL resource = resource(Paths.get("OSGI-INF").resolve(keyFile())); //$NON-NLS-1$ |
There was a problem hiding this comment.
Should we have PassageBundlePath later to encapsulate a way to find the info like this?
We may want to store the licensing information under a subfolder later, like they store bundle properties under OSGI-INF/l10n
There was a problem hiding this comment.
Thought about that, but lots of questions arised. This implementation sticks to the current functionality to keep status quo where it's possible. Let's do it when we actually will need it.
- fix typos in error messages Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BundleKeykeeperover the new (1.0) interfacesBundleKeykeeper