Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564819 - API revision | conditions | stream codecs review #275

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  • start redesigning StreamCodec interface
  • invite NamedData-based coverage for public string literals
    (encryption algorithm and key size)

Signed-off-by: elena.parovyshnaya [email protected]

 - start redesigning StreamCodec interface
 - invite `NamedData`-based coverage for public string literals
(encryption algorithm and key size)

Signed-off-by: elena.parovyshnaya <[email protected]>
 - add missing license header

Signed-off-by: elena.parovyshnaya <[email protected]>
 - add missing license header

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #275 into master will decrease coverage by 0.49%.
The diff coverage is 2.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   12.42%   11.93%   -0.50%     
==========================================
  Files         631      639       +8     
  Lines       15753    15673      -80     
  Branches     1198     1181      -17     
==========================================
- Hits         1958     1870      -88     
- Misses      13751    13755       +4     
- Partials       44       48       +4     
Impacted Files Coverage Δ
...passage/lic/internal/api/io/DigestExpectation.java 0.00% <0.00%> (ø)
...ssage/lic/internal/api/io/EncryptionAlgorithm.java 0.00% <0.00%> (ø)
...passage/lic/internal/api/io/EncryptionKeySize.java 0.00% <0.00%> (ø)
.../eclipse/passage/lic/base/LicensingProperties.java 84.21% <ø> (ø)
...e/lic/base/requirements/LicensingRequirements.java 87.23% <ø> (-6.42%) ⬇️
.../org/eclipse/passage/lic/internal/base/Access.java 0.00% <ø> (ø)
...passage/lic/internal/base/BaseLicensedProduct.java 72.72% <ø> (+50.14%) ⬆️
...sage/lic/internal/base/InvalidLicensedProduct.java 0.00% <ø> (ø)
...clipse/passage/lic/internal/base/Requirements.java 64.28% <ø> (-6.31%) ⬇️
...ge/lic/internal/base/conditions/BaseCondition.java 100.00% <ø> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebd01a...ef50662. Read the comment docs.

@eparovyshnaya
Copy link
Contributor Author

Codacy complains on unused imports in LicensingProperties class, which are demanded by javadoc and not actually unused. I suppose the complain is the Codacy bug.

@eparovyshnaya eparovyshnaya requested a review from ruspl-afed July 2, 2020 06:31
@ruspl-afed ruspl-afed self-requested a review July 2, 2020 14:53
@eparovyshnaya eparovyshnaya merged commit 05db8f9 into master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants