Bug 564420 conditions | move HC condition miner to new interfaces #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Handle remove conditions request parameters:
- user role
- action type
- create dedicated data-classes for `ConditionAction` and `UserRole`
- invite proper NamedData implementation to handle constant string
literals (`LicensingAction` and `LicensingRole` )
- deprecate previous public constant-dirven way to work with actions
and role
2.Implement request URL composition
3. Append new bundle for HC tests. It contains only stub for Request
test
Signed-off-by: elena.parovyshnaya <[email protected]>
- .project-file to new test plug-in Signed-off-by: elena.parovyshnaya <[email protected]>
- add missing license header Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 11.97% 11.92% -0.06%
==========================================
Files 625 629 +4
Lines 15500 15570 +70
Branches 1179 1179
==========================================
Hits 1856 1856
- Misses 13599 13669 +70
Partials 45 45
Continue to review full report at Codecov.
|
ruspl-afed
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle remove conditions request parameters:
ConditionActionandUserRoleLicensingActionandLicensingRole)Signed-off-by: elena.parovyshnaya [email protected]