Bug 564420 conditions | move HC condition miner to new interfaces #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rework appealing to licensing server coordinate definition settings: hide property name string literal - implement settings retrieval service - extend available PassageFileExtensions with `.settings` files required to store licensing server connection credentials Signed-off-by: elena.parovyshnaya <[email protected]>
- add missed license header Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 11.67% 11.98% +0.31%
==========================================
Files 619 624 +5
Lines 15409 15484 +75
Branches 1174 1178 +4
==========================================
+ Hits 1799 1856 +57
- Misses 13565 13583 +18
Partials 45 45
Continue to review full report at Codecov.
|
- add tests for Settings read service Signed-off-by: elena.parovyshnaya <[email protected]>
- fix typos in test names Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
requested changes
Jun 27, 2020
....passage.lic.base.tests/src/org/eclipse/passage/lic/internal/base/tests/io/SettingsTest.java
Show resolved
Hide resolved
- add missed license header Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.settingsfiles required to store licensing server connection credentialsSigned-off-by: elena.parovyshnaya [email protected]