Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564328 API revision | conditions | rethink key interfaces #251

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

eparovyshnaya
Copy link
Contributor

relates to 561540

base implementation of condition interfaces

Signed-off-by: elena.parovyshnaya [email protected]

> relates to 561540

base implementation of `condition` interfaces


Signed-off-by: elena.parovyshnaya <[email protected]>
add license header


Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya requested a review from ruspl-afed June 18, 2020 09:40
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #251 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #251      +/-   ##
=========================================
- Coverage    9.72%   9.66%   -0.07%     
=========================================
  Files         563     575      +12     
  Lines       14866   14965      +99     
  Branches     1161    1168       +7     
=========================================
  Hits         1446    1446              
- Misses      13382   13481      +99     
  Partials       38      38              
Impacted Files Coverage Δ
...ge/lic/internal/api/conditions/EvaluationType.java 0.00% <0.00%> (ø)
...ge/lic/internal/base/conditions/BaseCondition.java 0.00% <0.00%> (ø)
...al/base/conditions/BaseEvaluationInstructions.java 0.00% <0.00%> (ø)
...rnal/base/conditions/BaseValidityPeriodClosed.java 0.00% <0.00%> (ø)
...lic/internal/base/conditions/BaseVersionMatch.java 0.00% <0.00%> (ø)
...ternal/base/conditions/MatchingRuleCompatible.java 0.00% <0.00%> (ø)
.../internal/base/conditions/MatchingRuleDefault.java 0.00% <0.00%> (ø)
...ternal/base/conditions/MatchingRuleEquivalent.java 0.00% <0.00%> (ø)
...nal/base/conditions/MatchingRuleForIdentifier.java 0.00% <0.00%> (ø)
...al/base/conditions/MatchingRuleGreaterOrEqual.java 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93e2d9...9746087. Read the comment docs.

 - prohibit null as a ctor argument


Signed-off-by: elena.parovyshnaya <[email protected]>
@ruspl-afed ruspl-afed self-requested a review June 18, 2020 10:20
@eparovyshnaya eparovyshnaya merged commit 9067a76 into master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants