Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564328 API revision | conditions | rethink key interfaces #249

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

eparovyshnaya
Copy link
Contributor

relates to 561540

  • contract tests for lic.version API
  • base implementation for lic.version API
  • tests for the implementation

Signed-off-by: elena.parovyshnaya [email protected]

> relates to 561540

 - contract tests for `lic.version` API
 - base implementation for `lic.version` API
 - tests for the implementation

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #249 into master will increase coverage by 0.57%.
The diff coverage is 93.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #249      +/-   ##
===========================================
+ Coverage      9.15%   9.72%   +0.57%     
===========================================
  Files           553     563      +10     
  Lines         14765   14866     +101     
  Branches       1158    1161       +3     
===========================================
+ Hits           1352    1446      +94     
- Misses        13376   13382       +6     
- Partials         37      38       +1     
Impacted Files Coverage Δ Complexity Δ
...passage/lic/internal/base/version/BaseVersion.java 33.33% <33.33%> (ø) 0.00 <0.00> (?)
...sage/lic/internal/base/version/DefaultVersion.java 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...api/version/tests/SemanticVersionContractTest.java 77.77% <77.77%> (ø) 0.00 <0.00> (?)
...lic/internal/base/version/BaseSemanticVersion.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...ge/lic/internal/base/version/NumericalVersion.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...passage/lic/internal/base/version/SafeVersion.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...age/lic/api/version/tests/VersionContractTest.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...c/internal/base/tests/version/SafeVersionTest.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...sion/contract/BaseSemanticVersionContractTest.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...ests/version/contract/SafeVersionContractTest.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee690a6...34ed865. Read the comment docs.

@eparovyshnaya eparovyshnaya requested a review from ruspl-afed June 17, 2020 18:05
@eparovyshnaya eparovyshnaya merged commit 2d54c4b into master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants