Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 564328 API revision | conditions | rethink key interfaces #248

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  • add our general settings to 'api.test' bundle
  • fix externalization issues
  • extend ValidityPeriods contract tests

Signed-off-by: elena.parovyshnaya [email protected]

 - add our general settings to 'api.test' bundle
 - fix externalization issues
 - extend `ValidityPeriod`s contract tests

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #248 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #248      +/-   ##
===========================================
- Coverage      9.16%   9.15%   -0.02%     
  Complexity        2       2              
===========================================
  Files           553     553              
  Lines         14747   14765      +18     
  Branches       1158    1158              
===========================================
  Hits           1352    1352              
- Misses        13358   13376      +18     
  Partials         37      37              
Impacted Files Coverage Δ Complexity Δ
...api/conditions/tests/MatchingRuleContractTest.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...itions/tests/ValidityPeriodClosedContractTest.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nditions/tests/ValidityPeriodOpenContractTest.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/api/tests/ResolvedRequirementsContractTest.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...lipse/passage/lic/api/tests/fakes/FakeFeature.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/passage/lic/api/tests/fakes/FakeRequirement.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../lic/api/tests/fakes/FakeResolvedRequirements.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c8f1e...ee690a6. Read the comment docs.

@eparovyshnaya eparovyshnaya requested review from ruspl-afed and removed request for ruspl-afed June 17, 2020 13:38
@eparovyshnaya eparovyshnaya merged commit 9e9f0ac into master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants