Bug 564328 API revision | conditions | rethink key interfaces #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'LicensingCondition' interface reconstructed Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
===========================================
- Coverage 9.20% 9.19% -0.01%
Complexity 2 2
===========================================
Files 548 549 +1
Lines 14694 14708 +14
Branches 1156 1156
===========================================
Hits 1352 1352
- Misses 13305 13319 +14
Partials 37 37
Continue to review full report at Codecov.
|
- update MatchingRule documentation Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
reviewed
Jun 16, 2020
...ipse.passage.lic.api/src/org/eclipse/passage/lic/internal/api/conditions/EvaluationType.java
Outdated
Show resolved
Hide resolved
...clipse.passage.lic.api/src/org/eclipse/passage/lic/internal/api/conditions/VersionMatch.java
Show resolved
Hide resolved
- get rid of Time EvaluationType as it is far from implementation - fix EvaluationType javadoc Signed-off-by: elena.parovyshnaya <[email protected]>
- fix VersionMatch javadoc Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: elena.parovyshnaya [email protected]