564282 API revision: question extensibility #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decision has been taken to close extensibility for critical access cycle parts and 'seal' final services assembly for security aims. Thus: - `registry` implementation altered to have final readonly registry class - extensibility of requirement resolution services registry is closed: readonly registry is used - both requirement resolution services we have now(BundleRequirements and ComponentRequirements) are detached from OSGi to be accessible for sealing. - contract tests are designed for `Framework` and resuirement resolution service (new `lic.api.tests` bundle) - 'seal.demo' bundle is added to supply final assembly of passage runtime (packed instance of `Framework` interface) for out-of-the-box facilities demontration purposes - `seal.demo.tests` bundle contains both contract and implementational tests for current `DemoFramework` - `demo` feature is appended Signed-off-by: elena.parovyshnaya <[email protected]>
- remove outdated OSGi-component life cycle methods Signed-off-by: elena.parovyshnaya <[email protected]>
- add single workable test among all the abstract ones to 'api.tests' bundle to make sure-fire go Signed-off-by: elena.parovyshnaya <[email protected]>
- document framework contract test idea Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
requested changes
Jun 15, 2020
...ssage.seal.demo.tests/src/org/eclipse/passage/seal/demo/tests/DemoFrameworkContractTest.java
Show resolved
Hide resolved
...ssage.seal.demo.tests/src/org/eclipse/passage/seal/demo/tests/DemoFrameworkContractTest.java
Outdated
Show resolved
Hide resolved
...assage.seal.demo.tests/src/org/eclipse/passage/seal/demo/tests/DemoFrameworkContentTest.java
Show resolved
Hide resolved
.../org.eclipse.passage.seal.demo/src/org/eclipse/passage/seal/internal/demo/DemoFramework.java
Show resolved
Hide resolved
...equinox/src/org/eclipse/passage/lic/internal/equinox/requirements/ComponentRequirements.java
Outdated
Show resolved
Hide resolved
...se.passage.lic.base/src/org/eclipse/passage/lic/internal/base/registry/ReadOnlyRegistry.java
Show resolved
Hide resolved
...clipse.passage.lic.base/src/org/eclipse/passage/lic/internal/base/registry/BaseRegistry.java
Show resolved
Hide resolved
eparovyshnaya
added
the
pr::wip
- finalize fields ex- OSGi components Signed-off-by: elena.parovyshnaya <[email protected]>
- explain, generalize and extend api contract tests - reimplement existing requirement resolution services tests basing on contract assumptions checking - test requirement resolution services registry, supplied by demo framework (make sure it follows the contract) Signed-off-by: elena.parovyshnaya <[email protected]>
Fix code review findings: - add license headers - specify exact version of dependencies Signed-off-by: elena.parovyshnaya <[email protected]>
Fix existing requirement resolution services tests Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
===========================================
- Coverage 9.21% 9.17% -0.05%
- Complexity 0 2 +2
===========================================
Files 539 549 +10
Lines 14626 14741 +115
Branches 1157 1162 +5
===========================================
+ Hits 1348 1352 +4
- Misses 13242 13352 +110
- Partials 36 37 +1
Continue to review full report at Codecov.
|
eparovyshnaya
removed
the
pr::wip
ruspl-afed
approved these changes
Jun 16, 2020
Hide 'internal' package Signed-off-by: elena.parovyshnaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision has been taken to close extensibility for critical access cycle parts and 'seal' final services assembly for security aims. Thus, there:
registryimplementation is altered to have final readonly registry classBundleRequirementsandComponentRequirements) are detached from OSGi to be accessible for sealingFrameworkand resuirement resolution service (newlic.api.testsbundle)seal.demobundle is added to supply final assembly of passage runtime (packed instance ofFrameworkinterface) for out-of-the-box facilities demontration purposesseal.demo.testsbundle contains both contract and content tests for currentDemoFrameworkdemofeature is appended