Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Passage] Licensing dialog should show "does not match" items #235

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

ruspl-afed
Copy link
Contributor

Restriction code 403 means "does not match"

Signed-off-by: Alexander Fedorov [email protected]

Restriction code 403 means "does not match"

Signed-off-by: Alexander Fedorov <[email protected]>
@ruspl-afed ruspl-afed requested a review from eparovyshnaya June 2, 2020 16:16
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #235 into master will decrease coverage by 0.01%.
The diff coverage is 12.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #235      +/-   ##
=========================================
- Coverage    9.51%   9.49%   -0.02%     
=========================================
  Files         518     518              
  Lines       14187   14191       +4     
  Branches     1150    1150              
=========================================
- Hits         1350    1348       -2     
- Misses      12800   12807       +7     
+ Partials       37      36       -1     
Impacted Files Coverage Δ
...pse/passage/lic/base/access/BaseAccessManager.java 77.04% <0.00%> (ø)
...passage/lic/internal/jface/i18n/JFaceMessages.java 0.00% <ø> (ø)
...jface/viewers/RestrictionVerdictViewerAdapter.java 0.00% <0.00%> (ø)
...passage/lic/base/access/BasePermissionEmitter.java 47.36% <14.28%> (-8.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f66109...cd2a956. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 9f59867 into master Jun 2, 2020
@ruspl-afed ruspl-afed deleted the 563848 branch June 13, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants