Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

561553 #210

Merged
merged 6 commits into from
May 14, 2020
Merged

561553 #210

merged 6 commits into from
May 14, 2020

Conversation

eparovyshnaya
Copy link
Contributor

Implement sample e4 app with two Requirements decared by OSGi _Component_s, ittustrate the usage in UI.

Closes 561553

  - design base ui prototype for the FF-based project
  - declare two licensing requirements via SOGi components

Signed-off-by: elena.parovyshnaya <[email protected]>
  - evolve the sample, intermediate state

Signed-off-by: elena.parovyshnaya <[email protected]>
  - implement sample template project with two requirements declared by
means of Component

Signed-off-by: elena.parovyshnaya <[email protected]>
 - memo for the further interface improvement

Signed-off-by: elena.parovyshnaya <[email protected]>
 - wipe `org.eclipse.pde.ds.core.builder` as the need in it was
temporary

Signed-off-by: elena.parovyshnaya <[email protected]>
 - wipe icons, will develop a ui without images

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #210 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #210      +/-   ##
=========================================
- Coverage    9.55%   9.54%   -0.02%     
=========================================
  Files         518     518              
  Lines       13957   13974      +17     
  Branches     1130    1129       -1     
=========================================
  Hits         1334    1334              
- Misses      12586   12603      +17     
  Partials       37      37              
Impacted Files Coverage Δ
.../pde/ui/templates/BaseLicensedTemplateSection.java 0.00% <0.00%> (ø)
...s/LicensedE4FullFeatherProductTemplateSection.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937a26c...a836bcf. Read the comment docs.

Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @eparovyshnaya !!!
Looking forward to see more people enjoing this!

@eparovyshnaya eparovyshnaya merged commit bfece37 into master May 14, 2020
@ruspl-afed ruspl-afed deleted the 561553 branch May 23, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants