Passage/feature/add support attach for mail client #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added javax.mail for target Signed-off-by: Sergei Kovalchuk <[email protected]>
Added Licensing Mail interfaces Signed-off-by: Sergei Kovalchuk <[email protected]>
Added Mail faced Signed-off-by: Sergei Kovalchuk <[email protected]>
Implemented mail support service. Signed-off-by: Sergei Kovalchuk <[email protected]>
Pom.xml corrected Signed-off-by: Sergei Kovalchuk <[email protected]>
Project files Signed-off-by: Sergei Kovalchuk <[email protected]>
Test added for mail attach Signed-off-by: Sergei Kovalchuk <[email protected]>
Added attachment parameter to LicensingResult Invoked eml preparation from mail support faced Signed-off-by: Sergei Kovalchuk <[email protected]>
Integrated mail support to the wizard. Signed-off-by: Sergei Kovalchuk <[email protected]>
Some variables were renamed. Signed-off-by: Sergei Kovalchuk <[email protected]>
Removed plyglot.build.properties files Signed-off-by: Sergei Kovalchuk <[email protected]>
Reworked to Optional Signed-off-by: Sergei Kovalchuk <[email protected]>
ruspl-afed
requested changes
Oct 8, 2019
...c.dashboard.ui/src/org/eclipse/passage/loc/dashboard/ui/wizards/IssueLicenseDetailsPage.java
Outdated
Show resolved
Hide resolved
...ge.loc.dashboard.ui/src/org/eclipse/passage/loc/dashboard/ui/wizards/IssueLicenseWizard.java
Outdated
Show resolved
Hide resolved
....passage.lic.mail.tests/src/org/eclipse/passage/lic/mail/tests/LicensingMailServiceTest.java
Outdated
Show resolved
Hide resolved
....passage.lic.mail.tests/src/org/eclipse/passage/lic/mail/tests/LicensingMailServiceTest.java
Outdated
Show resolved
Hide resolved
Rework: copyright; x-internal,the job were extracted to own class.
Renamed method to be more generic, Added copyrights, Changed bundle dependency order Signed-off-by: Sergei Kovalchuk <[email protected]>
Field modifier move to final; Added more test cases; The LicensingMailService reached coverage of 100%
Declare explicit dependency for javax.activation Signed-off-by: Alexander Fedorov <[email protected]>
Declare explicit dependency for javax.activation Signed-off-by: Alexander Fedorov <[email protected]>
Normalize LIC Mail bundle Signed-off-by: Alexander Fedorov <[email protected]>
Normalize LicensingMailImpl Signed-off-by: Alexander Fedorov <[email protected]>
Normalize copyright Signed-off-by: Alexander Fedorov <[email protected]>
Support multiple attachments Signed-off-by: Alexander Fedorov <[email protected]>
Remove LicensingMails static accessor Signed-off-by: Alexander Fedorov <[email protected]>
Rename LicensingMail to Mailing Signed-off-by: Alexander Fedorov <[email protected]>
Rename LicensingMailDescriptor to EmailDescriptor Signed-off-by: Alexander Fedorov <[email protected]>
Rename LicensingMailDescriptorImpl to EmailDescriptorImpl Signed-off-by: Alexander Fedorov <[email protected]>
Rename LicensingMailImpl to MailImpl Signed-off-by: Alexander Fedorov <[email protected]>
Repackage to org.eclipse.passage.lic.email Signed-off-by: Alexander Fedorov <[email protected]>
Extract org.eclipse.passage.lic.email bundle Signed-off-by: Alexander Fedorov <[email protected]>
Fix org.eclipse.passage.lic.email bundle copyrights Signed-off-by: Alexander Fedorov <[email protected]>
ruspl-afed
approved these changes
Nov 3, 2019
ruspl-afed
deleted the
passage/feature/add_support_attach_for_mail_client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 550956 - [Passage] Support mail attachment …
Were integrated Licensing Mail Service allowing to export mail descriptor to "EML" format from licensing wizard.