Bug 552722 design Registry for lic.api RequirementResolvers #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ResolvedRequirementsRegistry` interface is invited to host the registry - `EquinoxResolvedRequirementsRegistry` OSGi-based implementation is created to exploit OSGi DI and autowiring - `EquinoxFramework` supplies the registry - `EquinoxFrameworkSupplierTest` tests the runtime availability of the framework, the ResolvedRequirements registry and both our predefined implementations (`BundleRequirements` and `ComponentRequirement) Signed-off-by: elena.parovyshnaya <[email protected]>
- add license headers to new files Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
===========================================
- Coverage 9.18% 9.15% -0.03%
Complexity 105 105
===========================================
Files 505 507 +2
Lines 13799 13833 +34
Branches 1126 1128 +2
===========================================
Hits 1267 1267
- Misses 12497 12531 +34
Partials 35 35
Continue to review full report at Codecov.
|
ruspl-afed
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolvedRequirementsRegistryinterface is invited to host theregistry
EquinoxResolvedRequirementsRegistryOSGi-based implementation iscreated to exploit OSGi DI and autowiring
EquinoxFrameworksupplies the registryEquinoxFrameworkSupplierTesttests the runtime availability of theframework, the ResolvedRequirements registry and both our predefined
implementations (
BundleRequirementsand `ComponentRequirement)Signed-off-by: elena.parovyshnaya [email protected]