548115 - [Passage] provide ability to create product version from issue license wizard : part 2 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use proper type names Signed-off-by: Alexander Fedorov <[email protected]>
Extract facilities to get localized type names Signed-off-by: Alexander Fedorov <[email protected]>
Shift nested wizard window for a while Signed-off-by: Alexander Fedorov <[email protected]>
Rework LocWorkbench#createDomainResource method Signed-off-by: Alexander Fedorov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
===========================================
- Coverage 9.18% 9.08% -0.11%
Complexity 105 105
===========================================
Files 503 516 +13
Lines 13831 13989 +158
Branches 1126 1135 +9
===========================================
Hits 1271 1271
- Misses 12525 12683 +158
Partials 35 35
Continue to review full report at Codecov.
|
eparovyshnaya
approved these changes
Apr 6, 2020
....workbench/src/org/eclipse/passage/loc/internal/workbench/wizards/InnerClassifierWizard.java
Outdated
Show resolved
Hide resolved
...kbench/src/org/eclipse/passage/loc/internal/workbench/wizards/InnerClassifierWizardPage.java
Outdated
Show resolved
Hide resolved
...ard.ui/src/org/eclipse/passage/moveto/lic/internal/features/model/FeaturesClassMetadata.java
Show resolved
Hide resolved
Add tests for EClassResources Add tests for EClassName Signed-off-by: Alexander Fedorov <[email protected]>
Changed to method references Signed-off-by: Alexander Fedorov <[email protected]>
Replace with ClassifierInitializer#newObjectName with EObjectDefaultName Signed-off-by: Alexander Fedorov <[email protected]>
Replace with ClassifierInitializer#newObjectIdentifier with EObjectDefaultIdentifier Signed-off-by: Alexander Fedorov <[email protected]>
|
@eparovyshnaya please have a look, I fixed all the labels for nested wizards |
ruspl-afed
changed the title
ruspl-afed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several annoying issues for "select or create" scenario: