Bug 561435 API revision: requirements resolution: test coverage #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BundleRequirements test set is complete Signed-off-by: elena.parovyshnaya <[email protected]>
- add license header to the new class Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
===========================================
- Coverage 9.24% 9.24% -0.01%
Complexity 105 105
===========================================
Files 492 492
Lines 13704 13705 +1
Branches 1123 1123
===========================================
Hits 1267 1267
- Misses 12402 12403 +1
Partials 35 35
Continue to review full report at Codecov.
|
ruspl-afed
requested changes
Apr 5, 2020
...age.lic.equinox/src/org/eclipse/passage/lic/internal/equinox/i18n/EquinoxMessages.properties
Outdated
Show resolved
Hide resolved
...sage.lic.equinox/src/org/eclipse/passage/lic/internal/equinox/requirements/BundleVendor.java
Outdated
Show resolved
Hide resolved
...nox/src/org/eclipse/passage/lic/internal/equinox/requirements/RequirementFromCapability.java
Outdated
Show resolved
Hide resolved
- fix code review findings: i18n for "unknown vendor", suspicious print, error in an i18n-message template format Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-
BundleRequirementsservice test set is completeSigned-off-by: elena.parovyshnaya [email protected]