Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

561771 [Passage] Remove outdated code dedicated to select a User #178

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

ruspl-afed
Copy link
Contributor

This is a part of Passage LOC clean-up: replace all the static code used to select a User with new facilities

Removed unused UserIdentifierRendererService
Removed unused UserIdentifierRenderer

Signed-off-by: Alexander Fedorov <[email protected]>
Removed UsersUi#selectUserDescriptor and usages

Signed-off-by: Alexander Fedorov <[email protected]>
@ruspl-afed ruspl-afed requested a review from eparovyshnaya April 4, 2020 13:54
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #178 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #178      +/-   ##
===========================================
+ Coverage      9.23%   9.25%   +0.02%     
  Complexity      105     105              
===========================================
  Files           493     491       -2     
  Lines         13715   13674      -41     
  Branches       1119    1116       -3     
===========================================
  Hits           1266    1266              
+ Misses        12414   12373      -41     
  Partials         35      35              
Impacted Files Coverage Δ Complexity Δ
...nal/licenses/ui/handlers/LicenseExportHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../src/org/eclipse/passage/loc/users/ui/UsersUi.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e9f4b...08bf1b0. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 11b0eda into master Apr 4, 2020
@eparovyshnaya eparovyshnaya deleted the 561771 branch April 6, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants