Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

561436 - API revision: requirements resolution: equinox services #174

Merged
merged 4 commits into from
Mar 26, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  • turn RestrictionLevel to a data-class, which is critical to the
    design
  • put BundleRequirements service code in order

 - turn `RestrictionLevel` to a data-class, which is critical to the
design
  - put `BundleRequirements` service code in order

Signed-off-by: elena.parovyshnaya <[email protected]>
 - avoid direct usage of `null`

Signed-off-by: elena.parovyshnaya <[email protected]>
 - make requirement resolving service `final`

Signed-off-by: elena.parovyshnaya <[email protected]>
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #174 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #174      +/-   ##
===========================================
- Coverage      9.41%   9.35%   -0.06%     
  Complexity      105     105              
===========================================
  Files           473     477       +4     
  Lines         13449   13528      +79     
  Branches       1115    1117       +2     
===========================================
  Hits           1266    1266              
- Misses        12148   12227      +79     
  Partials         35      35              
Impacted Files Coverage Δ Complexity Δ
...ic/internal/api/restrictions/RestrictionLevel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...al/base/requirements/UnsatisfiableRequirement.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../lic/equinox/requirements/EquinoxRequirements.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...age/lic/internal/equinox/i18n/EquinoxMessages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...equinox/requirements/BundleCapabilityResolver.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ernal/equinox/requirements/BundleRequirements.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ements/LicensingFeatureCapabilitiesFromBundle.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...l/equinox/requirements/RequirementsFromBundle.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...uinox/requirements/RequirementsFromCapability.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...pse/passage/lic/internal/emf/i18n/EmfMessages.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437c06c...26cd4f3. Read the comment docs.

 - fix compound variable name

Signed-off-by: elena.parovyshnaya <[email protected]>
@eparovyshnaya eparovyshnaya merged commit 7ff2d4b into master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants