561248 design client API entry point #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new Plug-in project template `LicensedE4FullFeatherProduct is added
to `ldc.pde.ui.templates` to illustrate new api usage from developer's
point of view
- `lic.api` changes
- Registry API is moved to the right `internal` package
- two base interfaces are added to `internal` part to denote the
main entry point for a client (developer): `Passage` and `Framework`
- `lic.base` changes
- `BaseLicensingConfiguration` is moved to `internal` (safe as it
was of package local visibility) and published for usage
- `LicensingConfigurations` static utils are deprecated
- Registry-client constructions are moved to the right `internal`
package
- `lic.e4.ui` changes
- existing `LicensingAddon` is deprecated
- new `E4LicensingAddon` is invited to `internal` part to be built
over the API under construction
- `lic.equinox` changes
- `ApplicationConfigurations` static utils set is deprecated
- new `internal` part implements (1) building a
LicensingConfiguration from IApplicationContext (2) invites empty
implementations for main entry client points (used by Newly invited
E4LicensingAddon)
Signed-off-by: elena.parovyshnaya <[email protected]>
- add license headers Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
===========================================
- Coverage 9.49% 9.48% -0.02%
Complexity 105 105
===========================================
Files 440 452 +12
Lines 13102 13259 +157
Branches 1104 1111 +7
===========================================
+ Hits 1244 1257 +13
- Misses 11823 11967 +144
Partials 35 35
Continue to review full report at Codecov.
|
ruspl-afed
requested changes
Mar 23, 2020
...eclipse/passage/ldc/internal/pde/ui/templates/LicensedE4FullFeatherProductContentWizard.java
Outdated
Show resolved
Hide resolved
...lipse/passage/ldc/internal/pde/ui/templates/LicensedE4FullFeatherProductTemplateSection.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/internal/api/Framework.java
Show resolved
Hide resolved
bundles/org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/internal/api/Passage.java
Show resolved
Hide resolved
bundles/org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/internal/api/Passage.java
Outdated
Show resolved
Hide resolved
...assage.lic.base/src/org/eclipse/passage/lic/internal/base/InvalidLicensingConfiguration.java
Outdated
Show resolved
Hide resolved
...eclipse/passage/ldc/internal/pde/ui/templates/LicensedE4FullFeatherProductContentWizard.java
Outdated
Show resolved
Hide resolved
...lipse/passage/ldc/internal/pde/ui/templates/LicensedE4FullFeatherProductTemplateSection.java
Outdated
Show resolved
Hide resolved
...es/src/org/eclipse/passage/ldc/internal/pde/ui/templates/LicensedE4ProductContentWizard.java
Show resolved
Hide resolved
...lipse.passage.lic.equinox/src/org/eclipse/passage/lic/equinox/ApplicationConfigurations.java
Show resolved
Hide resolved
- fix license headers, append javadoc and user-friendly error messages Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 561248 - [Passage] design client API entry point
LicensedE4FullFeatherProduct is added toldc.pde.ui.templates` to illustrate new api usage from developer'spoint of view
lic.apichangesinternalpackageinternalpart to denote themain entry point for a client (developer):
PassageandFrameworklic.basechangesBaseLicensingConfigurationis moved tointernal(safe as itwas of package local visibility) and published for usage
LicensingConfigurationsstatic utils are deprecatedinternalpackage
lic.e4.uichangesLicensingAddonis deprecatedE4LicensingAddonis invited tointernalpart to be builtover the API under construction
lic.equinoxchangesApplicationConfigurationsstatic utils set is deprecatedinternalpart implements (1) building aLicensingConfiguration from IApplicationContext (2) invites empty
implementations for main entry client points (used by Newly invited
E4LicensingAddon)
Signed-off-by: elena.parovyshnaya [email protected]