559091 - generic API for service registry #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first glance raw implementation Signed-off-by: elena.parovyshnaya <[email protected]>
- base (runtime storing) Registry implementation Signed-off-by: elena.parovyshnaya <[email protected]>
- first design version and raw implementation Signed-off-by: elena.parovyshnaya <[email protected]>
- license header and tailing new-lines Signed-off-by: elena.parovyshnaya <[email protected]>
- formatting errors fixed Signed-off-by: elena.parovyshnaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
===========================================
- Coverage 9.53% 9.49% -0.05%
Complexity 105 105
===========================================
Files 438 440 +2
Lines 13046 13102 +56
Branches 1104 1104
===========================================
Hits 1244 1244
- Misses 11767 11823 +56
Partials 35 35
Continue to review full report at Codecov.
|
ruspl-afed
requested changes
Mar 18, 2020
...eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Configuration.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Registry.java
Show resolved
Hide resolved
...eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Configuration.java
Outdated
Show resolved
Hide resolved
...s/org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Service.java
Outdated
Show resolved
Hide resolved
...org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/ServiceId.java
Show resolved
Hide resolved
Code review fixes: - Service interface is parametrized with ServiceId interface implementation type - @since-tags are removed from all the existing docs - Configuration interfaces is documented, other docs are yet to come Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
requested changes
Mar 19, 2020
...eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Configuration.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Registry.java
Show resolved
Hide resolved
...org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/ServiceId.java
Show resolved
Hide resolved
...s/org.eclipse.passage.lic.api/src/org/eclipse/passage/lic/api/internal/registry/Service.java
Outdated
Show resolved
Hide resolved
Code review fixes: - Configuration interfaces is removed Signed-off-by: elena.parovyshnaya <[email protected]>
ruspl-afed
approved these changes
Mar 19, 2020
|
Closes 559091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first design version and raw implementation