Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 560476 project template PassageE4 produces unworkable solution #149

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

eparovyshnaya
Copy link
Contributor

  • fix ProductFQN generation for RCP product plug-in generated over
    Passage Ex templates

Signed-off-by: elena.parovyshnaya [email protected]

 - fix ProductFQN generation for RCP product plug-in generated over
Passage Ex templates

Signed-off-by: elena.parovyshnaya <[email protected]>
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please file a bug to cover this with unit tests somehow. I think we will need to extract everything to UI-less part and then check the created project structure.

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #149 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #149      +/-   ##
===========================================
- Coverage       9.4%   9.34%   -0.06%     
  Complexity      105     105              
===========================================
  Files           442     445       +3     
  Lines         13212   13288      +76     
  Branches       1119    1127       +8     
===========================================
  Hits           1242    1242              
- Misses        11934   12010      +76     
  Partials         36      36
Impacted Files Coverage Δ Complexity Δ
...ui/templates/LicensedE3ProductTemplateSection.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ui/templates/LicensedE4ProductTemplateSection.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...licenses/ui/handlers/CreateLicensePlanHandler.java 0% <0%> (ø) 0% <0%> (?)
...nal/licenses/ui/handlers/LicenseExportHandler.java 0% <0%> (ø) 0% <0%> (?)
...l/licenses/ui/handlers/OpenLicensePlanHandler.java 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd982fc...3dc2a92. Read the comment docs.

@eparovyshnaya eparovyshnaya merged commit 9608c4d into master Feb 26, 2020
@eparovyshnaya
Copy link
Contributor Author

@ruspl-afed , done: 560552 ticket for test coverage.

Closes 560476.

@ruspl-afed ruspl-afed deleted the 560476 branch March 1, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants