-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 560181 - [Passage] add billing core basic implementation #147
Conversation
Signed-off-by: Nikifor Fedorov <[email protected]>
added license counting Signed-off-by: Nikifor Fedorov <[email protected]>
removed changes from properties files Signed-off-by: Nikifor Fedorov <[email protected]>
restored streams formatting Signed-off-by: Nikifor Fedorov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
===========================================
- Coverage 9.51% 9.41% -0.11%
- Complexity 103 105 +2
===========================================
Files 424 440 +16
Lines 12830 13193 +363
Branches 1107 1118 +11
===========================================
+ Hits 1221 1242 +21
- Misses 11573 11915 +342
Partials 36 36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thanks a lot!
Just a few notes from my side.
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Outdated
Show resolved
Hide resolved
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Outdated
Show resolved
Hide resolved
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Show resolved
Hide resolved
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Outdated
Show resolved
Hide resolved
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Outdated
Show resolved
Hide resolved
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Outdated
Show resolved
Hide resolved
...passage.loc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/UserLicenses.java
Outdated
Show resolved
Hide resolved
....loc.billing.core.tests/src/org/eclipse/passage/loc/billing/core/tests/UserLicensesTest.java
Show resolved
Hide resolved
all issues except for testing were resolved Signed-off-by: Nikifor Fedorov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely redone with local dsl!
Just minor notes.
...e.loc.billing.core.tests/src/org/eclipse/passage/loc/billing/core/tests/StringsProvider.java
Show resolved
Hide resolved
...billing.core.tests/src/org/eclipse/passage/loc/billing/core/tests/FakeLicenseDescriptor.java
Show resolved
Hide resolved
...e.loc.billing.core.tests/src/org/eclipse/passage/loc/billing/core/tests/StringsProvider.java
Outdated
Show resolved
Hide resolved
....loc.billing.core.tests/src/org/eclipse/passage/loc/billing/core/tests/UserLicensesTest.java
Outdated
Show resolved
Hide resolved
some refactor Signed-off-by: Nikifor Fedorov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine, only two JavaDoc notes left.
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Outdated
Show resolved
Hide resolved
...oc.billing.core/src/org/eclipse/passage/loc/internal/billing/core/ProductVersionLicense.java
Show resolved
Hide resolved
fixed some javadoc issues Signed-off-by: Nikifor Fedorov <[email protected]>
added NonNull mention in javadoc Signed-off-by: Nikifor Fedorov <[email protected]>
added UsersLicenses javadoc Signed-off-by: Nikifor Fedorov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Nikifor!
added licenses counting
Signed-off-by: Nikifor Fedorov [email protected]