Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 560181 - [Passage] add billing core basic implementation #147

Merged
merged 9 commits into from
Feb 26, 2020
Merged

Bug 560181 - [Passage] add billing core basic implementation #147

merged 9 commits into from
Feb 26, 2020

Conversation

zelenyhleb
Copy link
Contributor

added licenses counting

Signed-off-by: Nikifor Fedorov [email protected]

added license counting

Signed-off-by: Nikifor Fedorov <[email protected]>
removed changes from properties files

Signed-off-by: Nikifor Fedorov <[email protected]>
restored streams formatting

Signed-off-by: Nikifor Fedorov <[email protected]>
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #147 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #147      +/-   ##
===========================================
- Coverage      9.51%   9.41%   -0.11%     
- Complexity      103     105       +2     
===========================================
  Files           424     440      +16     
  Lines         12830   13193     +363     
  Branches       1107    1118      +11     
===========================================
+ Hits           1221    1242      +21     
- Misses        11573   11915     +342     
  Partials         36      36
Impacted Files Coverage Δ Complexity Δ
...assage/loc/internal/billing/core/UserLicenses.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/internal/billing/core/ProductVersionLicense.java 0% <0%> (ø) 0 <0> (?)
...org/eclipse/passage/loc/workbench/LocWokbench.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...loc/internal/workbench/i18n/WorkbenchMessages.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ge/loc/internal/users/ui/i18n/UsersUiMessages.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...se/passage/loc/report/internal/core/Customers.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../eclipse/passage/loc/report/internal/core/Csv.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ge/loc/internal/licenses/ui/SelectLicensePlan.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../dashboard/ui/wizards/IssueLicenseRequestPage.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...x/requirements/ComponentConfigurationResolver.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0250c5c...0e2d604. Read the comment docs.

Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks a lot!
Just a few notes from my side.

all issues except for testing were resolved

Signed-off-by: Nikifor Fedorov <[email protected]>
@eparovyshnaya eparovyshnaya self-requested a review February 25, 2020 18:07
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely redone with local dsl!
Just minor notes.

@eparovyshnaya eparovyshnaya removed the request for review from ruspl-afed February 26, 2020 06:54
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, only two JavaDoc notes left.

fixed some javadoc issues

Signed-off-by: Nikifor Fedorov <[email protected]>
added NonNull mention in javadoc

Signed-off-by: Nikifor Fedorov <[email protected]>
added UsersLicenses javadoc

Signed-off-by: Nikifor Fedorov <[email protected]>
Copy link
Contributor

@eparovyshnaya eparovyshnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nikifor!

@eparovyshnaya eparovyshnaya merged commit 5f5ccad into eclipse-passage:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants